<html>
<head><meta charset="utf-8"><title>Creating a pull request · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html">Creating a pull request</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="207368246"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207368246" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Griffiths <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207368246">(Aug 19 2020 at 04:06)</a>:</h4>
<p>Hey, I've been working on <a href="https://github.com/rust-lang/rust/issues/60302">#60302</a>, however lately I've been somewhat swamped with uni work and regular work. I've got some changes I've made that have been working towards completing this, however, there is still a lot of work to go. I'd like to keep working on this, but it could take me a while, would this be a decent case where I could create a pull request, get the work I've already done looked at (and hopefully merged) and continue working on the rest of issue, or would the team prefer that I either, step away from the issue and let someone with the time to look at it take over, or I continue working on it when I can?</p>



<a name="207368311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207368311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207368311">(Aug 19 2020 at 04:08)</a>:</h4>
<p>If you have something partway done absolutely feel free to open a PR :)</p>



<a name="207368317"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207368317" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207368317">(Aug 19 2020 at 04:08)</a>:</h4>
<p>That avoids people trying to work on it concurrently without knowing too</p>



<a name="207368546"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207368546" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Griffiths <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207368546">(Aug 19 2020 at 04:15)</a>:</h4>
<p>Fantastic. I'll create a PR now. Hopefully I do it all right <span aria-label="grimacing" class="emoji emoji-1f62c" role="img" title="grimacing">:grimacing:</span></p>



<a name="207370327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207370327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207370327">(Aug 19 2020 at 04:53)</a>:</h4>
<p>There's instructions at <a href="https://rustc-dev-guide.rust-lang.org/conventions.html#how-to-structure-your-pr">https://rustc-dev-guide.rust-lang.org/conventions.html#how-to-structure-your-pr</a></p>



<a name="207370330"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207370330" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207370330">(Aug 19 2020 at 04:53)</a>:</h4>
<p>But if you do something different it's fine, that's what review is for :)</p>



<a name="207371039"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207371039" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Griffiths <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207371039">(Aug 19 2020 at 05:10)</a>:</h4>
<p>Oooh, okay, should have read that section way sooner. I have a merge commit. Is there a way to fix that with Git, or will I need to do something else?</p>



<a name="207371115"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207371115" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lokathor <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207371115">(Aug 19 2020 at 05:12)</a>:</h4>
<p>(I've also been bitten by this before, why aren't merge commits allowed anyway?)</p>



<a name="207371218"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207371218" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Griffiths <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207371218">(Aug 19 2020 at 05:14)</a>:</h4>
<p>I've read elsewhere that they make the commit history messy. This is my first open source project, so normally in my own projects, this kind of thing hasn't been an issue. I just wasn't thinking about it when I was working on this.</p>



<a name="207373370"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207373370" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207373370">(Aug 19 2020 at 06:06)</a>:</h4>
<p>Merge commits make an historic non-linear, which is viewed as messy since it makes it harder to search for bugs with git bisect for example</p>



<a name="207373580"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207373580" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Griffiths <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207373580">(Aug 19 2020 at 06:12)</a>:</h4>
<p>As a note, when I was looking for info about how to structure my PR, I checked out the "A typical contribution" section of the Guide to Rustc development book, because based on the available sections, that seemed the most likely. I wouldn't have thought to look in the Coding Conventions sections (I wouldn't consider a PR a piece of code is why I'm guessing)</p>



<a name="207401489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207401489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207401489">(Aug 19 2020 at 12:39)</a>:</h4>
<p>yeah that could probably be redone</p>



<a name="207401493"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207401493" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207401493">(Aug 19 2020 at 12:39)</a>:</h4>
<p>let me open an issue</p>



<a name="207401640"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207401640" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207401640">(Aug 19 2020 at 12:40)</a>:</h4>
<p><a href="https://github.com/rust-lang/rustc-dev-guide/issues/831">https://github.com/rust-lang/rustc-dev-guide/issues/831</a></p>



<a name="207402376"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Creating%20a%20pull%20request/near/207402376" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Creating.20a.20pull.20request.html#207402376">(Aug 19 2020 at 12:47)</a>:</h4>
<blockquote>
<p>Merge commits make an historic non-linear, </p>
</blockquote>
<p>Note that history will already be non-linear as there are multiple branches happening concurrently anyway. Removing merge commits _reduces_ the non-linearity though.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>